Unfocus of RGB / HEX fields causes color value to change#1
Unfocus of RGB / HEX fields causes color value to change#1Reggino wants to merge 3 commits intoosnoek:masterfrom
Conversation
… values were return as 0.31, 0.12, 0.11 and sometimes they where returned as 131, 32, 11. Besides: the values seemed a bit off.... Implemented new RGB2HSV and HSV2RGB logic and standardized the use...
|
Hi Kingsquare, Thanks for the feedback. Sorry for the late response. I will review your code and merge it with the modifications I have made myself and will then merge those into the trunk. As for the "me" versus "this" it's a question of personal preference :) Will let you know when your changes have been merged. Cheers, Olav |
|
Hi Olav, Thanx! And again: great work on the plug-in, i love it! But please do re-consider removing 'me' references, because i think it has more implications than personal preferences: it means extra & unneeded lines of code, introducing extra unneeded variables and why not name it 'this' since 'this' is how JavaScript describes the scope? Using native language constructs is i.m.h.o. better the using your own type of referencing to the same this.... Thanks again! Tim |
Hi Olav!
Great work on the ColorPicker component. It works great!
I found a small bug however. When a user fills out some HEX value (e.g. AAAAAA) and the focuses the next field, the color value gets re-calculated and changes. This way, a user can not fill out the exact RBG value.
This commit fixes this issue by providing a rgb OR hsv value as the new color value. The field is updated accordingly.