Skip to content

Regenerate#94

Merged
joch merged 1 commit intomainfrom
joch/fix-underscore
Jun 27, 2025
Merged

Regenerate#94
joch merged 1 commit intomainfrom
joch/fix-underscore

Conversation

@joch
Copy link
Member

@joch joch commented Jun 27, 2025

No description provided.

@joch joch merged commit 2d22aba into main Jun 27, 2025
1 check passed
@joch joch deleted the joch/fix-underscore branch June 27, 2025 14:27
Copy link

@agentobot agentobot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️ agentobot[bot] Review

Area Observation Recommendation
Testing Entire Go-based tests/mockserver/ directory (100+ files) is removed. No obvious replacement tests added. Confirm CI no longer relies on these files and that equivalent coverage exists (e.g., via Speakeasy mock server or integration tests).
API Stability Public parameters input_input, type_type across SDK. This breaks existing user code and shadows Python’s built-in type. Consider adding keyword-only alias fields via Field(alias="input_") / Field(alias="type_") or bumping major version (2.0.0) to signal the breaking change.
Versioning Version raised to 1.1.0 only. Breaking rename may warrant 2.x per semver. Evaluate semver impact; update CHANGELOG to highlight breaking change.
Docs & Examples Most examples updated, but a quick grep shows type_="embedding" still in docs/quickstart.md line 87. Sweep docs for lingering underscores to avoid confusion.
Pydantic Models New model_config uses populate_by_name=True – good. But removal of aliases may break deserialization of stored payloads. Keep aliases for backward-compat or provide migration guide.
Built-in Shadowing Using parameter name type risks confusion with built-in type. Consider span_type or retain type_ internally while exposing type alias for JSON.

General Thoughts

  • ✅ Removing unused mockserver reduces repo bloat—nice!
  • 🛡️ Please ensure no stray references in workflows (docker-compose, Makefile, etc.).
  • 📝 Add migration notes in README/CHANGELOG so downstream users aren’t surprised.

Let me know if you’d like deeper line-level suggestions—happy to help!

agentobot[bot]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant