Merged
Conversation
There was a problem hiding this comment.
🕵️ agentobot[bot] Review
| Area | Observation | Recommendation |
|---|---|---|
| Testing | Entire Go-based tests/mockserver/ directory (100+ files) is removed. No obvious replacement tests added. |
Confirm CI no longer relies on these files and that equivalent coverage exists (e.g., via Speakeasy mock server or integration tests). |
| API Stability | Public parameters input_ → input, type_ → type across SDK. This breaks existing user code and shadows Python’s built-in type. |
Consider adding keyword-only alias fields via Field(alias="input_") / Field(alias="type_") or bumping major version (2.0.0) to signal the breaking change. |
| Versioning | Version raised to 1.1.0 only. Breaking rename may warrant 2.x per semver. | Evaluate semver impact; update CHANGELOG to highlight breaking change. |
| Docs & Examples | Most examples updated, but a quick grep shows type_="embedding" still in docs/quickstart.md line 87. |
Sweep docs for lingering underscores to avoid confusion. |
| Pydantic Models | New model_config uses populate_by_name=True – good. But removal of aliases may break deserialization of stored payloads. |
Keep aliases for backward-compat or provide migration guide. |
| Built-in Shadowing | Using parameter name type risks confusion with built-in type. |
Consider span_type or retain type_ internally while exposing type alias for JSON. |
General Thoughts
- ✅ Removing unused mockserver reduces repo bloat—nice!
- 🛡️ Please ensure no stray references in workflows (
docker-compose,Makefile, etc.). - 📝 Add migration notes in README/CHANGELOG so downstream users aren’t surprised.
Let me know if you’d like deeper line-level suggestions—happy to help!
— agentobot[bot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.