fix(routing): use HybridHistoryDelegate.state() in RouteAware callbacks#859
Merged
fix(routing): use HybridHistoryDelegate.state() in RouteAware callbacks#859
Conversation
HybridRouterChangeEvent bypasses HybridHistoryDelegate.state() and reads state directly from ModalRoute.settings.arguments. These tests verify the expected behavior once the fix is applied. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ks (#855) HybridRouterChangeEvent was reading state from ModalRoute.settings.arguments, bypassing the delegate entirely. Now checks for a delegate first so JS-side useLocation().state returns the correct data when a delegate is set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
andycall
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
didPop,didPopNext,didPush,didPushNext) in bothWebFRouterViewStateandWebFStatenow check for aHybridHistoryDelegatebefore reading route state, usingdelegate.state()instead ofModalRoute.settings.argumentswhen a delegate is setHybridHistoryModule.delegateso the callbacks can access itCloses #855
Test plan
cd webf && flutter test test/src/widget/hybrid_router_delegate_state_test.dart— all 3 tests pass🤖 Generated with Claude Code