Skip to content

fix(sdk): encapsulate fields with getters and setters in sdk classes #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cshamrick wants to merge 3 commits into
base: main
Choose a base branch
from

fix(sdk): configure source directories for maven-checkstyle-plugin

1b06dfa
Select commit
Loading
Failed to load commit list.
Draft

fix(sdk): encapsulate fields with getters and setters in sdk classes #313

fix(sdk): configure source directories for maven-checkstyle-plugin
1b06dfa
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 21, 2025 in 39s

Quality Gate failed

Failed conditions
65.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 618 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpT&open=AZqnJYOkqBDr1FukwIpT&pullRequest=313

Check failure on line 778 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpb&open=AZqnJYOkqBDr1FukwIpb&pullRequest=313

Check failure on line 779 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpc&open=AZqnJYOkqBDr1FukwIpc&pullRequest=313

Check warning on line 426 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpM&open=AZqnJYOkqBDr1FukwIpM&pullRequest=313

Check warning on line 366 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpJ&open=AZqnJYOkqBDr1FukwIpJ&pullRequest=313

Check warning on line 693 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpX&open=AZqnJYOkqBDr1FukwIpX&pullRequest=313

Check warning on line 563 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpP&open=AZqnJYOkqBDr1FukwIpP&pullRequest=313

Check warning on line 51 in sdk/src/main/java/io/opentdf/platform/sdk/Config.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYNnqBDr1FukwIpB&open=AZqnJYNnqBDr1FukwIpB&pullRequest=313

Check warning on line 617 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpS&open=AZqnJYOkqBDr1FukwIpS&pullRequest=313

Check failure on line 262 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpG&open=AZqnJYOkqBDr1FukwIpG&pullRequest=313

Check warning on line 428 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpO&open=AZqnJYOkqBDr1FukwIpO&pullRequest=313

Check warning on line 564 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpQ&open=AZqnJYOkqBDr1FukwIpQ&pullRequest=313

Check warning on line 425 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpL&open=AZqnJYOkqBDr1FukwIpL&pullRequest=313

Check warning on line 51 in sdk/src/main/java/io/opentdf/platform/sdk/Config.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYNnqBDr1FukwIpC&open=AZqnJYNnqBDr1FukwIpC&pullRequest=313

Check warning on line 427 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpN&open=AZqnJYOkqBDr1FukwIpN&pullRequest=313

Check failure on line 263 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpH&open=AZqnJYOkqBDr1FukwIpH&pullRequest=313

Check warning on line 692 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpW&open=AZqnJYOkqBDr1FukwIpW&pullRequest=313

Check warning on line 787 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpF&open=AZqnJYOkqBDr1FukwIpF&pullRequest=313

Check warning on line 696 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpa&open=AZqnJYOkqBDr1FukwIpa&pullRequest=313

Check warning on line 780 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "CDOffset" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpe&open=AZqnJYOkqBDr1FukwIpe&pullRequest=313

Check warning on line 62 in sdk/src/main/java/io/opentdf/platform/sdk/Config.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYNnqBDr1FukwIpD&open=AZqnJYNnqBDr1FukwIpD&pullRequest=313

Check warning on line 417 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpK&open=AZqnJYOkqBDr1FukwIpK&pullRequest=313

Check warning on line 623 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpU&open=AZqnJYOkqBDr1FukwIpU&pullRequest=313

Check warning on line 694 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpY&open=AZqnJYOkqBDr1FukwIpY&pullRequest=313

Check failure on line 781 in sdk/src/main/java/io/opentdf/platform/sdk/ZipWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AZqnJYOkqBDr1FukwIpd&open=AZqnJYOkqBDr1FukwIpd&pullRequest=313
View more details on SonarQubeCloud