Skip to content

Conversation

@csibbitt
Copy link
Contributor

@csibbitt csibbitt commented Dec 8, 2025

@openshift-ci openshift-ci bot requested review from olliewalsh and stuggi December 8, 2025 21:49
Copy link
Contributor

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, can we mark it draft until the depends on merges?

@csibbitt csibbitt marked this pull request as draft December 10, 2025 22:28
@csibbitt csibbitt marked this pull request as ready for review December 18, 2025 21:57
@openshift-ci openshift-ci bot requested review from fultonj and viroel December 18, 2025 21:57
@csibbitt
Copy link
Contributor Author

csibbitt commented Jan 5, 2026

CI Failure:

Summarizing 1 Failure:
  [FAIL] OpenStackOperator controller when Multiple target versions exist [It] updating targetVersion triggers a minor update workflow [Serial]
  /go/pkg/mod/github.com/openstack-k8s-operators/lib-common/modules/common@v0.6.1-0.20251215094837-5c05ea64c324/test/helpers/conditions.go:53

AFAICT this has nothing to do with this PR.

@csibbitt
Copy link
Contributor Author

csibbitt commented Jan 5, 2026

/retest

@csibbitt
Copy link
Contributor Author

csibbitt commented Jan 5, 2026

@slagle FYI, this is ready to merge because the related PR in edpm-ansible has merged, but there seems to be an unresolved problem elsewhere in the functional test.

@slagle
Copy link
Contributor

slagle commented Jan 5, 2026

/retest

@slagle
Copy link
Contributor

slagle commented Jan 5, 2026

@slagle FYI, this is ready to merge because the related PR in edpm-ansible has merged, but there seems to be an unresolved problem elsewhere in the functional test.

It will still need to pass. I've approved it and it should enter the merge queue if it passes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csibbitt, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 5, 2026
@csibbitt
Copy link
Contributor Author

csibbitt commented Jan 5, 2026

It failed for a different unrelated reason now.

• [FAILED] [55.928 seconds]

Dataplane NodeSet Test when Testing deployment filtering logic when Failed deployment followed by completed deployment [It] Should show all deployments in status and process completed deployment

/go/src/github.com/openstack-k8s-operators/operator/test/functional/dataplane/openstackdataplanenodeset_controller_test.go:1754

[...]

[FAILED] Timed out after 40.001s.

The function passed to Eventually failed at /go/pkg/mod/github.com/openstack-k8s-operators/lib-common/modules/common@v0.6.1-0.20251215094837-5c05ea64c324/test/helpers/conditions.go:49 with:

DeploymentReady condition is in an unexpected state. Expected: True, Actual: False, instance name: 1e00ac88-a615-4025-b01f-472734e7fab7/edpm-compute-nodeset-failsuccess, Conditions: [{Ready False Info 2026-01-05 20:55:19 +0000 UTC Requested Deployment in progress} {DeploymentReady False Info 2026-01-05 20:55:19 +0000 UTC Requested Deployment in progress} {InputReady True 2026-01-05 20:55:04 +0000 UTC Ready Input data complete} {NodeSetDNSDataReady True 2026-01-05 20:55:04 +0000 UTC Ready NodeSetDNSDataReady ready} {NodeSetIPReservationReady True 2026-01-05 20:55:04 +0000 UTC Ready NodeSetIPReservationReady ready} {ServiceAccountReady True 2026-01-05 20:55:04 +0000 UTC Ready ServiceAccount created} {SetupReady True 2026-01-05 20:55:04 +0000 UTC Ready Setup complete}]

Expected

<v1.ConditionStatus>: False

to equal

<v1.ConditionStatus>: True

In [It] at: /go/pkg/mod/github.com/openstack-k8s-operators/lib-common/modules/common@v0.6.1-0.20251215094837-5c05ea64c324/test/helpers/conditions.go:53 @ 01/05/26 20:56:00.32

@csibbitt
Copy link
Contributor Author

csibbitt commented Jan 5, 2026

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 81c0f87 into openstack-k8s-operators:main Jan 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants