Skip to content

SREP-2895: Add TargetGroupAttributes permissions to HCP CCM policy#2633

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
MitaliBhalla:SREP-2895
Feb 12, 2026
Merged

SREP-2895: Add TargetGroupAttributes permissions to HCP CCM policy#2633
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
MitaliBhalla:SREP-2895

Conversation

@MitaliBhalla
Copy link
Contributor

@MitaliBhalla MitaliBhalla commented Jan 28, 2026

Add elasticloadbalancing:DescribeTargetGroupAttributes and elasticloadbalancing:ModifyTargetGroupAttributes for NLB hairpin support.

Reference: OCPBUGS-65885, SREP-2895

What type of PR is this?

feature

What this PR does / why we need it?

Adds two missing AWS IAM permissions to the HCP kube controller manager (CCM) policy:
elasticloadbalancing:DescribeTargetGroupAttributes
elasticloadbalancing:ModifyTargetGroupAttributes
These permissions are required for the Cloud Controller Manager to support NLB hairpin traffic on private load balancers. Without them, LoadBalancer services with the preserve_client_ip.enabled=false target group attribute fail to provision.

Which Jira/Github issue(s) this PR fixes?

OCPBUGS-65885, SREP-2895
Reference : openshift/hypershift#7339

Fixes #
OCPBUGS-65885

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster

  • Included documentation changes with PR

  • If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]

Add elasticloadbalancing:DescribeTargetGroupAttributes and
elasticloadbalancing:ModifyTargetGroupAttributes for NLB hairpin support.

Reference: OCPBUGS-65885
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2026

@MitaliBhalla: This pull request references SREP-2895 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add elasticloadbalancing:DescribeTargetGroupAttributes and elasticloadbalancing:ModifyTargetGroupAttributes for NLB hairpin support.

Reference: OCPBUGS-65885, SREP-2895

What type of PR is this?

feature

What this PR does / why we need it?

Adds two missing AWS IAM permissions to the HCP kube controller manager (CCM) policy:
elasticloadbalancing:DescribeTargetGroupAttributes
elasticloadbalancing:ModifyTargetGroupAttributes
These permissions are required for the Cloud Controller Manager to support NLB hairpin traffic on private load balancers. Without them, LoadBalancer services with the preserve_client_ip.enabled=false target group attribute fail to provision.

Which Jira/Github issue(s) this PR fixes?

OCPBUGS-65885, SREP-2895
Reference : openshift/hypershift#7339

Fixes #
OCPBUGS-65885

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster

  • Included documentation changes with PR

  • If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bmeng and clcollins January 28, 2026 12:28
@bmeng
Copy link
Contributor

bmeng commented Feb 12, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, MitaliBhalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 67a2f2b into openshift:master Feb 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants