[release-4.18] OCPBUGS-74644: After OCL is enabled few phases in MCN are not updating as expected

[dkhater-redhat]

• What I did
  Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
• How to verify it

Enable OCL on a cluster
Apply a MachineConfig change
Watch oc get machineconfignode -w -o wide
Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL

• Description for the changelog

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkhater-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[djoshy]

/jira cherry-pick OCPBUGS-43435

[openshift-ci-robot]

@djoshy: Jira Issue OCPBUGS-43435 has been cloned as Jira Issue OCPBUGS-74644. Will retitle bug to link to clone.
/retitle OCPBUGS-74644: [release-4.18] After OCL is enabled few phases in MCN are not updating as expected

Details

In response to this:

/jira cherry-pick OCPBUGS-43435

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-74644, which is invalid:

• expected dependent Jira Issue OCPBUGS-43435 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

• What I did
  Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
• How to verify it

Enable OCL on a cluster
Apply a MachineConfig change
Watch oc get machineconfignode -w -o wide
Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL

• Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/retitle [release-4.18] OCPBUGS-74644: After OCL is enabled few phases in MCN are not updating as expected

[dkhater-redhat]

/jira refresh

[openshift-ci-robot]

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-74644, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-43435 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-43435 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dkhater-redhat]

/retest-required

[openshift-ci]

@dkhater-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.