[release-4.18] OCPBUGS-56898: Fix Cinder, Manila driver metrics#501
Conversation
We had configured the proxy sidecar container for the driver in the
controller Deployment, but the upstream it was pointing to did not
exist. Fix this by setting the --http-endpoint option. Per the upstream
docs [1]:
--http-endpoint <HTTP server>
This argument is optional.
The TCP network address where the HTTP server for providing metrics
for diagnostics, will listen (example: `:8080`).
The default is empty string, which means the server is disabled.
There's a bit of cleanup needed here to avoid hardcoding something which
is generated (via a loop-variable) elsewhere, but we'll do that
separately.
[1] https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.32/docs/cinder-csi-plugin/using-cinder-csi-plugin.md#command-line-arguments
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The openstack-manila driver does not currently support this. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
|
/verified later @stephenfin Assuming CI is good. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot, stephenfin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
This is an automated cherry-pick of #386
/assign stephenfin