Update OWNERS_ALIASES to include myself + "taanyas" and "marty-power"#2908
Update OWNERS_ALIASES to include myself + "taanyas" and "marty-power"#2908mattedallo wants to merge 1 commit intoopenshift:masterfrom
Conversation
… as reviewers, and clean up formatting. Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThe OWNERS_ALIASES file was updated to include three new aliases (marty-power, mattedallo, taanyas) in the core-reviewers section, along with minor whitespace corrections to existing entries for arkadeepsen, martinkennelly, and pperiyasamy. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
| core-reviewers: | ||
| - arghosh93 | ||
| - arkadeepsen | ||
| - arkadeepsen |
There was a problem hiding this comment.
was there a trailing whitespace? here and for peri? seems unrelated change hence asking
There was a problem hiding this comment.
yes, I removed them (actually AI did once I asked to order alphabetically :D )
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattedallo, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold I'd wait till Tanya becomes an org member, else its technically incorrect to add her github user handle from security perspective |
|
/verify-owners |
|
/remove-hold |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@mattedallo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
Update OWNERS_ALIASES to include myself ("mattedallo") + "taanyas" and "marty-power" as reviewers.