[WIP] CORENET-6562: CNCC rebase k8s to 1.35.0#202
[WIP] CORENET-6562: CNCC rebase k8s to 1.35.0#202yingwang-0320 wants to merge 1 commit intoopenshift:mainfrom
Conversation
Signed-off-by: Ying Wang <yingwang@rehat.com>
|
@yingwang-0320: This pull request references CORENET-6562 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yingwang-0320 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
| build_root_image: | ||
| name: release | ||
| namespace: openshift | ||
| tag: rhel-9-release-golang-1.24-openshift-4.22 |
There was a problem hiding this comment.
@yingwang-0320 , this is probably why the lint job is failing:
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
This file is usually bumped with automation like it was here for 4.22.
|
/test lint |
|
@yingwang-0320: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
➜ rg 'k8s.io|openshift' go.mod | rg -v 'indirect|module' | awk '{print "go get -u",$1}' | sh
go: downloading github.com/openshift/api v0.0.0-20260209232644-126cbbe24427
go: downloading k8s.io/api v0.34.1
go: downloading k8s.io/apimachinery v0.34.1
go: downloading sigs.k8s.io/structured-merge-diff/v6 v6.3.2
go: downloading golang.org/x/net v0.46.0
go: downloading golang.org/x/net v0.50.0
go: downloading golang.org/x/text v0.30.0
go: downloading golang.org/x/text v0.34.0
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/api@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: k8s.io/apimachinery@v0.35.0 requires go >= 1.25.0 (running go 1.24.5)
go: downloading github.com/openshift/api v0.0.0-20260107103503-6d35063ca179
go: upgraded github.com/openshift/api v0.0.0-20251106045556-627ea21fbf8c => v0.0.0-20260107103503-6d35063ca179
go: upgraded github.com/openshift/client-go v0.0.0-20251015124057-db0dee36e235 => v0.0.0-20260108185524-48f4ccfc4e13
go: downloading github.com/openshift/library-go v0.0.0-20260209094534-b6adacbfccda
go: downloading github.com/openshift/api v0.0.0-20260126183958-606bd613f9f7
go: downloading golang.org/x/crypto v0.45.0
go: upgraded github.com/openshift/api v0.0.0-20260107103503-6d35063ca179 => v0.0.0-20260126183958-606bd613f9f7
go: upgraded github.com/openshift/library-go v0.0.0-20251104164011-e9c2485b059c => v0.0.0-20260209094534-b6adacbfccda
go: upgraded golang.org/x/crypto v0.43.0 => v0.45.0
go: upgraded golang.org/x/net v0.46.0 => v0.47.0
go: upgraded golang.org/x/sys v0.37.0 => v0.38.0
go: upgraded golang.org/x/term v0.36.0 => v0.37.0
go: upgraded golang.org/x/text v0.30.0 => v0.31.0
go: k8s.io/api@v0.35.0 requires go >= 1.25.0; switching to go1.25.7
go: downloading go1.25.7 (darwin/arm64)
go: upgraded go 1.24.0 => 1.25.0
go: removed toolchain go1.24.5
go: upgraded github.com/onsi/gomega v1.36.1 => v1.38.2
go: upgraded k8s.io/api v0.34.1 => v0.35.0
go: upgraded k8s.io/apimachinery v0.34.1 => v0.35.0
go: upgraded k8s.io/client-go v0.34.1 => v0.35.0
go: downloading k8s.io/cloud-provider v0.35.0
go: downloading k8s.io/kube-openapi v0.0.0-20260127142750-a19766b6e2d4
go: downloading golang.org/x/term v0.40.0
go: downloading golang.org/x/oauth2 v0.35.0
go: downloading golang.org/x/sys v0.41.0
go: downloading go.opentelemetry.io/otel v1.36.0
go: downloading go.opentelemetry.io/otel/metric v1.36.0
go: downloading go.opentelemetry.io/otel/sdk/metric v1.36.0
go: downloading golang.org/x/crypto v0.48.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20250528174236-200df99c418a
go: downloading go.opentelemetry.io/otel/trace v1.36.0
go: downloading google.golang.org/grpc v1.72.2
go: downloading go.opentelemetry.io/otel/sdk v1.36.0
go: upgraded github.com/go-openapi/jsonpointer v0.22.1 => v0.22.4
go: upgraded github.com/go-openapi/jsonreference v0.21.2 => v0.21.4
go: upgraded github.com/go-openapi/swag v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/cmdutils v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/conv v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/fileutils v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/jsonname v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/jsonutils v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/loading v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/mangling v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/netutils v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/stringutils v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/typeutils v0.25.1 => v0.25.4
go: upgraded github.com/go-openapi/swag/yamlutils v0.25.1 => v0.25.4
go: upgraded github.com/google/gnostic-models v0.7.0 => v0.7.1
go: upgraded go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0 => v0.61.0
go: upgraded go.opentelemetry.io/otel v1.35.0 => v1.36.0
go: upgraded go.opentelemetry.io/otel/metric v1.35.0 => v1.36.0
go: upgraded go.opentelemetry.io/otel/trace v1.35.0 => v1.36.0
go: upgraded golang.org/x/crypto v0.45.0 => v0.48.0
go: upgraded golang.org/x/net v0.47.0 => v0.50.0
go: upgraded golang.org/x/oauth2 v0.32.0 => v0.35.0
go: upgraded golang.org/x/sys v0.38.0 => v0.41.0
go: upgraded golang.org/x/term v0.37.0 => v0.40.0
go: upgraded golang.org/x/text v0.31.0 => v0.34.0
go: upgraded google.golang.org/genproto/googleapis/rpc v0.0.0-20250303144028-a0af3efb3deb => v0.0.0-20250528174236-200df99c418a
go: upgraded google.golang.org/grpc v1.72.1 => v1.72.2
go: upgraded google.golang.org/protobuf v1.36.10 => v1.36.11
go: upgraded k8s.io/apiserver v0.34.1 => v0.35.0
go: upgraded k8s.io/cloud-provider v0.34.1 => v0.35.0
go: upgraded k8s.io/component-base v0.34.1 => v0.35.0
go: upgraded k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 => v0.0.0-20260127142750-a19766b6e2d4
go: upgraded k8s.io/utils v0.0.0-20251002143259-bc988d571ff4 => v0.0.0-20260108192941-914a6e750570
go: upgraded sigs.k8s.io/structured-merge-diff/v6 v6.3.0 => v6.3.2
go: downloading sigs.k8s.io/controller-runtime v0.23.1
go: downloading gomodules.xyz/jsonpatch/v2 v2.4.0
go: upgraded github.com/golang-jwt/jwt/v5 v5.2.2 => v5.3.0
go: upgraded github.com/prometheus/common v0.67.2 => v0.67.5
go: upgraded gomodules.xyz/jsonpatch/v2 v2.4.0 => v2.5.0
go: upgraded k8s.io/apiextensions-apiserver v0.34.1 => v0.35.0
go: upgraded sigs.k8s.io/controller-runtime v0.22.4 => v0.23.1
➜ go mod tidy
➜ go mod vendor
➜ make build
CGO_ENABLED=0 GO111MODULE=on go build -mod vendor -o _output/bin/cloud-network-config-controller cmd/cloud-network-config-controller/main.go
➜ make test
go test ./... -count=1
? github.com/openshift/cloud-network-config-controller/cmd/cloud-network-config-controller [no test files]
ok github.com/openshift/cloud-network-config-controller/pkg/cloudprivateipconfig 1.035s
ok github.com/openshift/cloud-network-config-controller/pkg/cloudprovider 1.472s
? github.com/openshift/cloud-network-config-controller/pkg/controller [no test files]
ok github.com/openshift/cloud-network-config-controller/pkg/controller/cloudprivateipconfig 1.754s
? github.com/openshift/cloud-network-config-controller/pkg/controller/configmap [no test files]
? github.com/openshift/cloud-network-config-controller/pkg/controller/node [no test files]
? github.com/openshift/cloud-network-config-controller/pkg/controller/secret [no test files]
? github.com/openshift/cloud-network-config-controller/pkg/signals [no test files]