Open
Conversation
jnan806
force-pushed
the
client_build_check
branch
from
f683364 to
0336218
Compare
jnan806
changed the title
sczyh30
reviewed
Feb 15, 2023
Member
sczyh30
left a comment
sczyh30
left a comment
There was a problem hiding this comment.
What if the provided port is invalid?
jnan806
force-pushed
the
client_build_check
branch
2 times, most recently
from
2ea0ba3 to
bc79ac1
Compare
Collaborator
Author
:) has improved, both host and port of endpoint will be checked |
jnan806
changed the title
jnan806
force-pushed
the
client_build_check
branch
from
bc79ac1 to
3a5bd92
Compare
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
jnan806
force-pushed
the
client_build_check
branch
from
3a5bd92 to
ab5ac1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiangnan Jia jnan0806@gmail.com
Describe what this PR does / why we need it
Add condition ckeck for OpenSergoClient.Builder.build()