You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
almost 3 times smaller fat images by removing unused alpine packages
original size: REPOSITORY TAG IMAGE ID CREATED SIZE test latest f3a4fb6875e7 About a minute ago 396MB
fix: REPOSITORY TAG IMAGE ID CREATED SIZE test-fix-size latest 6034bc75cd29 4 seconds ago 108MB test latest f3a4fb6875e7 2 minutes ago 396MB
Hello, thanks for the contribution. I understand what you are doing -- moving some packages to be auto-removed at the end. I also appreciate the significant size reduction....
But, this is a weird image. It was called fat because it is larger and has those many installed packages. Those weren't necessarily intended to be solely build-dependencies for luarocks itself, but also for many other common packages that seem to be needed by other rocks. It was also intended to be an example of deriving images from the base openresrty image.
I'm weary of changing the included packages. It might affect users who derive FROM it. If a new user is really concerned about size, they can see how to derive an as-slim-as-possible image from these.
However, maybe there is some other new image flavor (meaning like -fat) that is needed? Why/how are you using the fat images?
EDIT TO ADD: Maybe it's more OK to change the -fat contents with a significant tag change, like the forthcoming 1.21.4.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
almost 3 times smaller fat images by removing unused alpine packages
original size:
REPOSITORY TAG IMAGE ID CREATED SIZE test latest f3a4fb6875e7 About a minute ago 396MBfix:
REPOSITORY TAG IMAGE ID CREATED SIZE test-fix-size latest 6034bc75cd29 4 seconds ago 108MB test latest f3a4fb6875e7 2 minutes ago 396MB