[ENH] Replace asserts with proper if else Exception handling

[Omswastik-11]

Fixes #1581

[Omswastik-11]

Hi @fkiraly !! I would like to know you suggestion on this .

In openml\runs\run.py the _generate_arff_dict function is causing the above issue . so I created a new function _get_arff_attributes_for_task to reduce complexity is it ok ? or should I think of a alternate solution ?

[fkiraly]

Yes, looks reasonable for me for a first go, to isolate the if/else in a function.

More generally, from an architecture standpoint however, whenever I see a long list of if/elses on the argument class type, I think it is too high coupling and it should be either a method of the (task/argument) class or a visitor pattern.

Why: imagine you want to add a new task. Now you have to add another elif in all of these functions. This is absolutely not extensible.

This should be refactored - I would say, in another PR, after opening an issue with a plan - so the task itself, or a visitor, manages whatever is in the if/else.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 4.76190% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.00%. Comparing base (d18ca42) to head (40d7019).

Files with missing lines	Patch %	Lines
openml/runs/run.py	4.54%	21 Missing ⚠️
openml/runs/functions.py	7.14%	13 Missing ⚠️
openml/runs/trace.py	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   52.08%   52.00%   -0.09%     
==========================================
  Files          36       36              
  Lines        4360     4369       +9     
==========================================
+ Hits         2271     2272       +1     
- Misses       2089     2097       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[geetu040]

Good, just ran the tests in tests/test_runs/ to be sure of the refactor, and it's green.
Ready to be merged!