Open
Conversation
Member
Author
|
Hi @janvanrijn @joaquinvanschoren , it would be great if you could review this! These settings should be production-ready. |
Contributor
|
Looks good. This is only for docker, right? It doesn't affect the currently running production server? |
Contributor
joaquinvanschoren
left a comment
There was a problem hiding this comment.
Thanks! This looks fine as far as I can tell. Just left one note to make sure we can merge or not.
| ; Production Value: 1 | ||
| ; https://php.net/session.gc-probability | ||
| session.gc_probability = 1 | ||
| ; 2025-06-20 (Jos) - As in current production, we will run garbage collection manually, to avoid 1/1000th chance of 2sec delay (TODO, DONT MERGE LIKE THIS!!) |
Contributor
There was a problem hiding this comment.
Is this still a TODO or do you think we can merge it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the php settings to similar values as production.
The main time-drain was garbage collection. On production,
/usr/lib/php/sessioncleanis ran from crontab but.. it does not clean the code igniter sessions! Those sessions are only cleaned after a reboot:I did not fix this on current production. It is now fixed for the new deployment, as far as I can see. I tested it by setting
session.gc_maxlifetime=10(seconds) and using openml-services (docker compose).It would be great if anyone with some knowledge of PHP and Code Igniter garbage collection / session handling could take a look at this!