Move learning core methods to video config service#37634
Move learning core methods to video config service#37634
Conversation
7418e07 to
4df35f9
Compare
db9a5a1 to
3c7e50b
Compare
3c7e50b to
d361718
Compare
kdmccormick
left a comment
There was a problem hiding this comment.
Libraries are particular to edx-platform, so they should not be part of the service interface. Additionally, adding a static asset is something that is common to all blocks, not just video, so if it were to be part of a service, it would not make sense for the video_config service to have such a method.
Here's a proposal, which would introduce upload_transcript and delete_transcript as the video_config methods, hiding the Libraries details within the edx-platform service implementation: #37657 . Could you review?
Yes, I was also concerned related to these methods. Thanks for giving the next directions. Will review. |
|
Closed in favor of #37383 |
Move learning core methods directly used in Video XBlock to video config service
Some ignore imports has been added to setup.cfg to fix these