feat(fs): replace is_empty_disk with more precise has_valuable_data
#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `has_valuable_data()` to better determine whether a block device contains meaningful filesystem data: - When an expected filesystem type (`fs_hint`) is provided, it strictly checks for that type and errors if something else is detected. - Without a hint, it treats known partition tables like `PTTYPE="atari"` as non-valuable (workaround for util-linux bug), while considering any other detected signature as valuable data. - Update callers in `cryptpilot-crypt` and tests to use the new logic, flipping boolean expectations accordingly. This improves safety during volume initialization by avoiding accidental overwrites of unexpected but valid data. Signed-off-by: Kun Lai <laikun@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
has_valuable_data()to better determine whether a block device contains meaningful filesystem data:fs_hint) is provided, it strictly checks for that type and errors if something else is detected.PTTYPE="atari"as non-valuable (workaround for util-linux bug), while considering any other detected signature as valuable data.cryptpilot-cryptand tests to use the new logic, flipping boolean expectations accordingly.This improves safety during volume initialization by avoiding accidental overwrites of unexpected but valid data.