Add declarative config support for sensitive_query_parameters#8087
Add declarative config support for sensitive_query_parameters#8087trask wants to merge 1 commit intoopen-telemetry:mainfrom
sensitive_query_parameters#8087Conversation
| * @throws DeclarativeConfigException if an unexpected type is encountered accessing the property | ||
| */ | ||
| @Nullable | ||
| public static List<String> sensitiveQueryParameters(ConfigProvider configProvider) { |
There was a problem hiding this comment.
Do you like these helper functions?
There was a problem hiding this comment.
good question, I guess not really 😄
There was a problem hiding this comment.
My initial thought is that they would be helpful for instrumentation conform to these general config options. All the instrumentation in opentelemetry-java-instrumentation can leverage shared utils in that repo to do this type of thing, so its really only native instrumentation that would stand to benefit.
There was a problem hiding this comment.
I kind of like the explicitness of seeing the yaml path in the code.
But can see them being useful.
What's your thought about these methods handling default values (and never returning null)?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8087 +/- ##
============================================
- Coverage 90.22% 90.22% -0.01%
- Complexity 7606 7607 +1
============================================
Files 841 841
Lines 22938 22925 -13
Branches 2291 2291
============================================
- Hits 20695 20683 -12
+ Misses 1526 1525 -1
Partials 717 717 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Depends on open-telemetry/opentelemetry-configuration#531