Skip to content

Conversation

@dbarker
Copy link
Member

@dbarker dbarker commented Nov 23, 2025

Fixes #3538

To run clang-tidy on all header files we need to upgrade to version 20.1. This version adds the --exclude-header-filter argument enabling analysis of all project header files excluding the api/.../internal/absl headers.

Changes

  • upgrade the clang-tidy CI workflow and devcontainer to clang-tidy version 20 from version 18
  • adds a python script to parse the build logs and create a markdown report on the unique warnings found

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (bed305f) to head (be9b574).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3762      +/-   ##
==========================================
+ Coverage   89.95%   89.95%   +0.01%     
==========================================
  Files         225      225              
  Lines        7158     7163       +5     
==========================================
+ Hits         6438     6443       +5     
  Misses        720      720              

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff
Copy link
Member

@dbarker

The generated reports (seen in CI) are very nice.

@dbarker dbarker marked this pull request as ready for review December 15, 2025 00:59
@dbarker dbarker requested a review from a team as a code owner December 15, 2025 00:59
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work.

@marcalff marcalff merged commit 5fc4707 into open-telemetry:main Dec 15, 2025
67 checks passed
@dbarker dbarker deleted the upgrade_to_clang_tidy_20 branch December 15, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade clang-tidy version used in CI

2 participants