Remove unnecessary CAS guard from SubscriptionProvider.updateTopics()

[zhangchiqing]

Problem

updateTopics() refreshes peer subscription data every 10 minutes, used to penalize peers subscribing to unauthorized topics. An inverted CAS guard caused every other update to be skipped, doubling the check interval to 20 minutes.

Solution

Remove the CAS guard. It's unnecessary since updateTopics() is only called from a single-goroutine ticker loop—no concurrent calls are possible.

Summary by CodeRabbit

• Refactor
  • Simplified the subscription provider's topic update process to enhance system performance and maintainability without affecting user-facing functionality.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed atomic-based concurrency guard from SubscriptionProvider's topic update mechanism. The allTopicsUpdate atomic.Bool field and related CompareAndSwap logic were deleted, simplifying updateTopics to rely on single-threaded execution driven by a ticker loop instead of cross-goroutine synchronization.

Changes

Cohort / File(s)	Summary
Concurrency Simplification network/p2p/scoring/subscription_provider.go	Removed allTopicsUpdate atomic.Bool field and CompareAndSwap synchronization logic; updateTopics now assumes single-threaded execution via ticker loop, eliminating the concurrent update guard. Updated comments reflect single-goroutine usage pattern.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 No more atomic guards to hold the line,
The ticker now makes updates align,
Single-threaded, smooth, and serene,
Simplicity reigns in this concurrency scene!
One path forward, no locks to define. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing a CAS guard from the SubscriptionProvider.updateTopics() method to fix a logic bug that was skipping every other refresh.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch leo/fix-subscription-scroing-check

---

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!