This repository was archived by the owner on Feb 25, 2020. It is now read-only.
More flexible and explicit configuration of common-node application#72
Open
ptmt wants to merge 2 commits intoolegp:masterfrom
Open
More flexible and explicit configuration of common-node application#72ptmt wants to merge 2 commits intoolegp:masterfrom
ptmt wants to merge 2 commits intoolegp:masterfrom
Conversation
Owner
|
Comments from @alexlamsl:
Please fix. |
Author
|
Sure, looks reasonable, and jshint has warnings about this. As I said it 'not-for-merge' commit, mostly for demonstration what problem is there for me. Thanks for review, looking forward to contribute more quality code after some experiments. |
Author
|
updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is first commit in this pull request, nothing important.
The background. I would be happy to use both type of configuration: via command-line or via hash parameter. I use the code below in the commit to change port inside my environment where 8080 port is already taken with other application.
To conitinue I have few questions:
run.jswhich has as much command-line arguments as you can do specify?