Open
Conversation
Author
|
I gave it another shot to get rid of the overly strict requirements on the hyperscript implementation. And it looks I succeeded! Unfortunately I seem to run into the typescript issue below which makes it so that the hyperscript implementation can't have any overloads. This is a deal-breaker because the implementations need the overloads for correctness. So looks like the current commit is as good as it gets unfortunately. |
|
Support for this would be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides better type safetly by forwarding the types of the hyperscript implementation to the helper.
The types put some constraints in place that the actual code doesn't:
2 and 3 restrict both the hyperscript implementation and the generated helpers
I tried to get rid of these assumptions by "forwarding" the types entirely from the hyperscript implementation.
Unfortunately I'm either not smart enough to make that work or it's not possible.
Below is how far I got using that approach. It works in a few cases but R1 and R2 are too restricted somehow. When I add R3 things get more messed up.