rtmp-services,frontend: Add data-driven VOD track support#12985
rtmp-services,frontend: Add data-driven VOD track support#12985SpaceCrapaud wants to merge 2 commits intoobsproject:masterfrom
Conversation
PatTheMav
left a comment
There was a problem hiding this comment.
I'd like to think that this is a good idea, I'm unsure whether it wouldn't make sense to migrate Twitch in the service configuration file to supports this change in one fell swoop as well, rather then keeping the old hardcoded defaults around.
I think we should also move it for Twitch, yeah. Edit: Perhaps I'd even go so far as to say make the naming more generic and just call it |
203b0e7 to
3c08fa9
Compare
3c08fa9 to
d3b5bac
Compare
|
Hi @PatTheMav @derrod ! I removed the hardcoded Twitch implementation and fallback. It is now fully data-driven. Regarding the generic labeling, as I would need to edit every locale to make it consistent, I think it's better to do it in a follow-up (I can prepare it and push it as soon as this one is merged, along with adding our service to the JSON). Let me know if you prefer a complete PR. I'm not sure how far I'm supposed to go in one PR. |
Description
This PR adds a new supports_vod_track boolean property to the services JSON schema (v5), allowing streaming services to declare VOD track support directly in services.json instead of requiring hardcoded C++ changes.
Motivation and Context
Currently, VOD track support is hardcoded only for Twitch. Other services that support separate VOD audio tracks (for DMCA-safe music, multi-language, clean feed, etc.) have no way to enable this feature without modifying the OBS source code.
This change makes VOD track support data-driven, so any service can enable it by simply adding:
"supports_vod_track": trueto their service definition.A hardcoded Twitch fallback is kept for backward compatibility with existing services.json files that don't define this property (and to avoid messing with Twitch's current implementation).EDIT : The hardcoded Twitch implementation has been removed, Twitch VoD Track support is now defined directly in
service.json, as intended with this PR.Note that the label is still Twitch VoD Track, even if it's not for Twitch. I assume that making the label neutral for non-Twitch services across all locales would be better suited for a separate PR.
How Has This Been Tested?
Tested locally on OBS 32.0.4 on Fedora 43 and Windows 25H2 (dual boot).
AMD Ryzen 9 5950x - Nvidia RTX 3090 - 128Gb RAM
Types of changes
Checklist: