Conversation
push evaluator changes to prod
|
Visit the preview URL for this PR (updated for commit 8585eeb): https://dev-nwplus-admin--pr101-erping-evaluator-set-9k5l6grn.web.app (expires Fri, 27 Feb 2026 01:54:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c290bf9e2fac0401389f751f415cce4267517b51 |
tdanielles
approved these changes
Feb 17, 2026
minor: rename eval settings prop type
tdanielles
pushed a commit
that referenced
this pull request
Feb 18, 2026
* hotfix(evaluator): add additional response field for cmd-f we probably want to move these values into firestore eventually * Evaluator settings fixes (#101) * fix: evalutor settings modal overflow * fix: update step increment and error msg spacing * minor: rename eval settings prop type --------- Co-authored-by: Jae Wu <jaewuchun@gmail.com> --------- Co-authored-by: Erping <111095333+ErpingS@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Before
After
Explanation
Added scrollwheel to setting dialog for overflow and minor qol fixes
Other considerations