Skip to content

Conversation

@DominikSLK
Copy link

Closes #7

@nvx
Copy link
Owner

nvx commented Sep 5, 2022

Ooh nice PR. The only concern I have is your choice of separator , which can conflict with some item names, for example this is a currently valid item type minecraft:chest[facing=north,type=single,waterlogged=false]{Items:[{Slot:0b,id:"minecraft:grass_block",Count:1b}],Lock:

This is why I changed from , as the separator to | go figure.

Maybe !, or ^ or some other special character might be less likely to conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Selectable biomes

2 participants