Conversation
YouTube removed annotations (except cards and endscreens) on January 15, 2019. Remove unnecessary code
dgb
approved these changes
Dec 5, 2019
dgb
left a comment
dgb
left a comment
There was a problem hiding this comment.
Comments are just on some small things. LGTM
| @@ -56,34 +48,17 @@ def json_to_annotations(json) | |||
|
|
|||
| def annotation_class(data) | |||
| case data['style'] | |||
There was a problem hiding this comment.
Can these nested conditionals be simplified now? Seems like it could just be
if data['style'] == 'branding'
Annotations::Branding
else
Annotations::Card
end| expect(annotations[3].link[:type]).to be :website | ||
| expect(annotations[3].link[:new_window]).to be true | ||
|
|
||
| expect(annotations[4]).to be_a Yt::Annotations::Branding |
There was a problem hiding this comment.
This is a preexisting thing, but I'd prefer we tested this via behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #30