Add compatibility for new Gmail redesign#29
Open
scottberke wants to merge 1 commit intonquinlan:masterfrom
Open
Add compatibility for new Gmail redesign#29scottberke wants to merge 1 commit intonquinlan:masterfrom
scottberke wants to merge 1 commit intonquinlan:masterfrom
Conversation
Gmail redesign caused issues with the email ID. Location slug no longer corresponds to the email ID. The email ID or thread ID seems to be accessed by a number of other plugins from the `h2[data-legacy-thread-id]` element so this update pulls from that element as it's present in both new and classic Gmail. ServiceLink is also now inserted as an adjacent element to the span as the new redesign was repainting that element after the service link was being added.
Owner
|
This is awesome. I'll merge it this week! Thank you! |
Author
|
@nquinlan Awesome! Let me know if there are any issues or updates you want me to make to the PR. |
Owner
|
@scottberke I had an opportunity to review this, however it looks like this may introduce a race condition where |
Author
|
@nquinlan Been on vacation for the last week. I'll look at this sometime this week and update. Thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gmail redesign caused issues with pulling the email ID and subsequently accessing the raw email source. Location slug no longer corresponds to the email ID. The email ID or thread ID seems to be accessed by a number of other plugins from the
h2[data-legacy-thread-id]element so this update pulls from that element as it's present in both new and classic Gmail.ServiceLink is also now inserted as an adjacent element to the span as the new redesign was repainting that element after the service link was being added.