Open
Conversation
ohnishiakira
approved these changes
Mar 9, 2023
Member
ohnishiakira
left a comment
ohnishiakira
left a comment
There was a problem hiding this comment.
example/dest/sprite.svg の差分が見た目的に問題ないかだけ他の方にも見ていただきたいです。(自分の環境だと透明でよく分からず...)
npm run build:exampleするとこのSVGに変更が入るので、コミットしておくのは問題なさそうと思いました。
他の箇所はLGTMです！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm依存関係が古すぎるので
npm updateを実行しました動いてれば良い気がする