http: remove deprecated Client interface

[mscdex]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

• http

Description of change

This commit removes the old http Client API that has been (hard) deprecated since 2011/v0.7.0.

[mscdex]

CI: https://ci.nodejs.org/job/node-test-pull-request/3666/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker-xunit/47/
CI: https://ci.nodejs.org/job/node-test-pull-request/3668/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker-xunit/48/

[mscdex]

CI is green except for an unrelated failure on AIX. CITGM also looks good.

/cc @nodejs/http

[Fishrock123]

seems fine to me if ecosystem usage is low enough

[jasnell]

LGTM

[jasnell]

Putting on the 7.0.0 milestone

[mscdex]

/cc @nodejs/ctc Comments? Questions? Concerns? Paper? Plastic?

[jasnell]

Still LGTM... now if only we can get other ctc to weigh in ;-)

[bnoordhuis]

LGTM

[Fishrock123]

@ChALkeR are you able to check npm stats on this at all?

[ChALkeR]

@Fishrock123 Sorry, missed it! 😞
https://gist.github.com/ChALkeR/b5105c46643373adaf6ac6cd954d991b — here it is.

[Fishrock123]

Hmm, most of it looks pretty old to me.

[ChALkeR]

242 packages. Top 10 used ones:

 432816  "node-forge"
 425178  "newrelic"
 153046  "nodeunit"
 84993  "node-rest-client"
 62103  "graphviz"
 4878  "npm-registry-couchapp"
 4732  "websocket-client"
 3981  "commonjs-everywhere"
 3596  "pn"
 3502  "felix-couchdb"

Only 5 of those have more than 5000 downloads/month.

[mscdex]

• node-forge can be dismissed, the usage I found there was actually just it creating its own http namespace with its own createClient() implementation (which isn't even documented).
• newrelic attempts to wrap the old API, but the way it wraps them it first checks if it exists, and safely exits/returns in case the API does not exist, so that should not be a problem either.
• nodeunit is a legit case however and I filed a PR for it here.
• node-rest-client is also another legit case and I filed a PR for it here.
• graphviz hasn't been updated since 2014 with unanswered issues and PRs, so IMHO I'm not sure it makes sense to try and submit a PR to fix any usage there.
• npm-registry-couchapp is another legit case and I filed a PR for it here.
• websocket-client hasn't been updated since 2012, so IMHO I'm not sure it makes sense to try and update that module either.
• commonjs-everywhere similarly hasn't been updated since 2014
• pn should be safe since it checks for existence first
• felix-couchdb is another legit case and I filed a PR here.

[cjihrig]

LGTM. Doubled bagged.

[mscdex]

CI one last time before landing: https://ci.nodejs.org/job/node-test-pull-request/3879/
https://ci.nodejs.org/job/node-test-pull-request/3880/

EDIT: CI is green