Skip to content

tools: test building with --experimental-quic #61446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aduh95 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tools: test building with --experimental-quic #61446

aduh95 wants to merge 2 commits into from
+114 −64

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 19, 2026

c1277d6 is from #61444, which should land first. Taking it to a separate PR as we can't backport Nix changes further than v25.x.

mcollina and others added 2 commits January 19, 2026 18:12
@mcollina
quic: move quic behind compile time flag
c1277d6 
Move node:quic behind a compile-time flag, disabled by default.
Use --experimental-quic at configure time to enable.

- Add --experimental-quic flag to configure.py
- Add node_use_quic variable and HAVE_QUIC define
- Make QUIC sources conditional in node.gyp
- Move ngtcp2/nghttp3 deps under QUIC condition in node.gypi
- Update C++ guards to check HAVE_QUIC
- Update process.features.quic to check node_use_quic
@aduh95
tools: test building with --experimental-quic
88e8ed0
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jan 19, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 19, 2026

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 19, 2026
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Jan 19, 2026
@avivkeller avivkeller added the blocked PRs that are blocked by other issues or PRs. label Jan 19, 2026
@richardlau
Copy link
Member

richardlau commented Jan 20, 2026

c1277d6 is from #61444, which should land first. Taking it to a separate PR as we can't backport Nix changes further than v25.x.

AFAIK the quic stuff has been mostly labelled dont-land-on-v24.x and earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

blocked PRs that are blocked by other issues or PRs. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @richardlau @avivkeller @mcollina