-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
esm: ensure watch mode restarts after syntax errors #61232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Xstoudi
wants to merge
6
commits into
nodejs:main
Choose a base branch
from
Xstoudi:fix/watch-report-early
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move watch dependency reporting earlier in module resolution to ensure file dependencies are tracked even when parsing fails. Fixes: nodejs#61153
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61232 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.02%
==========================================
Files 704 704
Lines 208734 208760 +26
Branches 40271 40276 +5
==========================================
- Hits 184823 184822 -1
- Misses 15932 15947 +15
- Partials 7979 7991 +12
🚀 New features to boost your workflow:
|
Member
|
Can you add a test? |
avivkeller
approved these changes
Jan 1, 2026
Contributor
Author
|
Just added a test, let me know if that's too broad and shouldn't be tested through cli. |
joyeecheung
reviewed
Jan 3, 2026
aduh95
reviewed
Jan 4, 2026
MoLow
approved these changes
Jan 4, 2026
joyeecheung
approved these changes
Jan 6, 2026
Collaborator
juanarbol
approved these changes
Jan 13, 2026
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move watch dependency reporting earlier in module resolution to ensure file dependencies are tracked even when parsing fails.
Fixes: #61153