-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
events: remove redundant todo #60595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60595 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 704 704
Lines 208883 208881 -2
Branches 40334 40322 -12
=======================================
+ Hits 184890 184891 +1
+ Misses 15977 15973 -4
- Partials 8016 8017 +1
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Nov 6, 2025
lpinca
approved these changes
Nov 6, 2025
anonrig
approved these changes
Jan 19, 2026
UlisesGascon
approved these changes
Jan 19, 2026
Collaborator
Collaborator
|
Landed in 5f7c3a6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said by the person who put the todo in the first place, it has been redundant for a while now
We have
kWeakHandler: thisnowPR removes it to prevent confusion