Fix high priority issues: version sync, portable paths, and CI/CD#2
Merged
nittygritty-zzy merged 2 commits intomainfrom Oct 20, 2025
Merged
Conversation
This commit addresses three critical improvements identified in the initial
repository check:
1. Version Mismatch Fix:
- Update CLI version from 0.1.0 to 0.2.0 to match pyproject.toml
- Ensures users see correct version with --version flag
2. Portable Path Configuration:
- Replace hard-coded macOS paths (/Volumes/sandisk/*) with relative paths
- Use "data" as default directory for cross-platform compatibility
- Add clear documentation for production path overrides
- Maintains backward compatibility with environment variables
3. CI/CD Automation:
- Add comprehensive test workflow (test.yml)
* Runs unit and integration tests on Python 3.10, 3.11, 3.12
* Generates coverage reports
* Tests on push to main/develop and all PRs
- Add code quality workflow (quality.yml)
* Linting with ruff
* Type checking with mypy
* Security scanning with safety
* Format checking
These changes improve maintainability, portability, and automated quality
assurance for the project.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This commit fixes two test issues discovered in CI: 1. Pytest Collection Warning (test_base_ingestor.py): - Renamed TestIngestor to MockIngestor - Pytest was incorrectly treating the helper class as a test class - The class starts with "Test" but is a concrete implementation for testing - Updated all references in fixtures and assertions 2. Validator Test Failures (test_qlib_binary_writer.py): - Fixed bug in QlibBinaryValidator._validate_instruments() - Instruments file format is tab-separated: SYMBOL\tstart_date\tend_date - Validator was not splitting by tab, causing symbol lookups to fail - Now properly extracts just the symbol field (first column) - This fixes both test_validator_features and test_validator_full Test Results: - All 123 unit tests now pass (previously 2 failures, 1 warning) - test_base_ingestor.py: 11/11 passed - test_qlib_binary_writer.py: 20/20 passed (including previously failing tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses three critical improvements identified in the initial repository check:
Version Mismatch Fix:
Portable Path Configuration:
CI/CD Automation:
These changes improve maintainability, portability, and automated quality assurance for the project.
🤖 Generated with Claude Code