Add onLoad to the available props.#18
Open
soorajvnair wants to merge 1 commit intonitish24p:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, Great job on the library, I think it's useful to have onLoad property available, so that we're aware when the image has loaded, in my use-case i want to render couple of components only when the image has finished loading, currently that's not possible since the onLoad event is not available on the component.
i think there's already a great PR by @hosmelq [https://github.com//pull/16](Let user pass any attributes) about letting the user pass all available image properties to the container, if you guys decide to merge that PR then i think my use-case would be covered.
I have also used prettier to format the code, i think that keeps in line with the standard these days, where most libraries are using prettier to format the source code.
Once again, great job on the library. Well done. :)