Limit Workers to max. avail. CPUs

[kurtextrem]

Fixes #10

[manjula-dube]

One liner ifs can also be made an awesome one

!workerPoolCreated && createWorkerPool();

[kurtextrem]

I forgot a line, that's why I couldn't do the shortcut :)

[nitish24p]

change int => number

[kurtextrem]

Thank you, I'm new to flow!

[nitish24p]

What was the purpose of removing the listener from the constructor and moving it to CDM?

[kurtextrem]

I moved everything to the constructor back again. My original idea was that it should only load the image when truly needed, but the constructor is called before CDM.

[nitish24p]

Each IMageWorker component will now spawn 4 worker threads. As we've removed the worker.terminate call, will those threads still be active when a componentWillUnMount gets called?

[nitish24p]

can you run npm run eslint to see the lint errors and fix those

[nitish24p]

This will go into an infinite loop

[kurtextrem]

Why so?

[nitish24p]

when you say

i < window.navigator.hardwareConcurrency || 4

The browser starts evaluating from the left and this will be treated as
(i < window.navigator.hardwareConcurrency) || (4)
even if the value of i goes to say 200, the above will then become
200 < window.navigator.hardwareConcurrency || 4
Which will translate to false || 4 and will always be true

[nitish24p]

why remove this, where is the worker actually being spawned?

[kurtextrem]

moved to line 42

[nitish24p]

response is not defined here. When this fn is executed it will break you can change it to

response => response.blob()

[kurtextrem]

fixed

[kurtextrem]

@nitish24p I fixed the mistakes, sorry for those, I was in a hurry.

[nitish24p]

I think you will have to change this to a let and reassign it to a true, after the createWorkerPool fn is invoked. Else everytime there will be 4 workers created as workerPoolCreated will always be false

[nitish24p]

this should be workerObj.i as per your code

[kurtextrem]

There's a big flaw in my current implementation: .onmessage can only exist once it seems. Which means currently ever new instance of ImageWorker replaces the callback function.
This means we need something like a Observer pattern.

Edit: I've overlooked, that Workers have the .addEventListener interface too, so that's not a problem anymore.