fix NPE in BitmapShrinker #5612
Open
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahibi
requested changes
Dec 9, 2025
|
|
||
| // solution inspired by https://developer.android.com/topic/performance/graphics/load-bitmap | ||
| private fun decodeBitmap(path: String, requestedWidth: Int, requestedHeight: Int): Bitmap = | ||
| private fun decodeBitmap(path: String, requestedWidth: Int, requestedHeight: Int): Bitmap? = |
Collaborator
There was a problem hiding this comment.
Did you try out some things why it actually fails?
E.g. did you try with specials chars in path like in the other recent PR? So the same fix could be applied..
Contributor
Author
There was a problem hiding this comment.
This will happen due to an invalid or corrupt file, or if the bitmap is too large(running out of memory during decoding). In all these cases, decodeFile() returns null instead of an exception.
sowjanyakch
force-pushed
the
bugfix/5600/fixNPE
branch
from
7ff7044 to
aa9bd48
Compare
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
sowjanyakch
force-pushed
the
bugfix/5600/fixNPE
branch
from
aa9bd48 to
e408160
Compare
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5612.apk |
Contributor
rapterjet2004
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5600
🚧 TODO
🏁 Checklist
/backport to stable-xx.x