Screenshot tests tooling #16233
Open
Screenshot tests tooling #16233
+60
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flavor was changed in nextcloud#15062, bf46332, from gplay to generic, but not all instances were adjusted. Signed-off-by: Philipp Hasper <vcs@hasper.info>
PhilLab
force-pushed
the
ph/screenshot_tests_tooling
branch
from
aa9c104 to
e1cff4e
Compare
Since 002f61a, the 'shot' dependency is excluded from the normal build, so it requires appropriate preconditions to be executed. Otherwise, the gradle task `genericDebugExecuteScreenshotTests` will not even be available. You can either ensure the appropriate setup manually, or better use the utility scripts. To facilitate the latter, some documentation was added as well. Signed-off-by: Philipp Hasper <vcs@hasper.info>
The AVD setup was only done automatically when executing updateScreenshots.sh. The lines were copied from there, but long-term, the exact AVD configuration as well as emulator parameters should rather be stored somewhere shared. Signed-off-by: Philipp Hasper <vcs@hasper.info>
PhilLab
added
3. to review
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing documentation sent you on the wrong track, as the 'shot' dependency is excluded from the normal build, so it requires appropriate preconditions to be executed. Otherwise, the gradle task
genericDebugExecuteScreenshotTestswill not even be available.