feat: option for propagationHeaders which are used in fetch patch#484
Open
lemusthelroy wants to merge 6 commits intomainfrom
Open
feat: option for propagationHeaders which are used in fetch patch#484lemusthelroy wants to merge 6 commits intomainfrom
lemusthelroy wants to merge 6 commits intomainfrom
Conversation
lemusthelroy
commented
Oct 15, 2025
| }, | ||
| }) | ||
|
|
||
| Object.defineProperty(globalThis, GET_TRACE_CONTEXT_FORWARDER, { |
Author
There was a problem hiding this comment.
not totally convinced this is the best way to make this forwarder accessible to the fetch instrumentation so may rework this
Member
|
@lemusthelroy Can you add a brief description that describes what problem this tries to solve and how it's meant to be used, so that it's easier to review? |
Author
Will do, sorry had been so focused on the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to manually pass headers that we wish to propagate. E.g. headers from a Netlify Request in a serverless function. These headers can then be used in the fetch instrumentation to ensure we can forward on the trace context.
E.g.