JGLWEB-130 add resource type to cloudinary to propery generate video url#118
Merged
RandyCupic merged 2 commits intomasterfrom Sep 10, 2025
Merged
JGLWEB-130 add resource type to cloudinary to propery generate video url#118RandyCupic merged 2 commits intomasterfrom
RandyCupic merged 2 commits intomasterfrom
Conversation
RandyCupic
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updated function
buildVariationUrlgets called when usingnetgen_remote_variationin twig, but it's missingresource_typein the options used with cloudinary's API. When the fn is then used with a video, the resulting URL ends up with/image/instead of/video/because cloudinary's code falls back toimageforresource_type, and that URL does not work.