Skip to content

Fix browser crash on signup rounds admin page #11178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbudin merged 1 commit into from
Jan 30, 2026
Merged

Fix browser crash on signup rounds admin page #11178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/javascript/SignupRoundsAdmin/MaximumEventSignupsPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,15 @@ export default function MaximumEventSignupsPreview({
);

const maximumEventSignups: EditingScheduledValue<string> = useMemo(() => {
const parsedSignupRounds = parseSignupRounds(signupRounds);
const parsedSignupRounds = parseSignupRounds(signupRounds, timezoneName);
return {
timespans: parsedSignupRounds.map((round) => ({
start: round.timespan.start?.toISO(),
finish: round.timespan.finish?.toISO(),
value: round.maximum_event_signups?.toString() ?? 'not_yet',
})),
};
}, [signupRounds]);
}, [signupRounds, timezoneName]);

return (
<ScheduledValuePreview
Expand Down
6 changes: 6 additions & 0 deletions app/javascript/UIComponents/ScheduledValuePreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,11 @@ function ScheduledValuePreviewCalendar<ValueType>({
return <></>;
}

// If there's only a single change point (not a range), don't render a calendar
if (earliestChange.toMillis() === latestChange.toMillis()) {
return <></>;
}

if (latestChange.diff(earliestChange, 'months').months > 6) {
return <>{t('scheduledValuePreview.tooLong')}</>;
}
Expand Down Expand Up @@ -259,6 +264,7 @@ function ScheduledValuePreview<ValueType>({
const [arrow, setArrow] = useState<HTMLDivElement | null>(null);
const dateElementMapRef = useRef(new Map<number, HTMLElement>());

// eslint-disable-next-line react-hooks/refs
const focusedDateElement = focusedDate ? (dateElementMapRef.current.get(focusedDate.valueOf()) ?? null) : null;

const { styles, attributes, state } = useLitformPopper(tooltip, focusedDateElement, arrow);
Expand Down
Loading