This repository was archived by the owner on Feb 9, 2021. It is now read-only.
Open
Conversation
@nbsdx this is worse than unnecesary, it prevents the compiler from implement RVO and NRVO which are much more efficient than a move operation. See: http://stackoverflow.com/questions/14856344/when-should-stdmove-be-used-on-a-function-return-value
Reduces 2-phase construction and more efficient in some cases, avoiding object construction if not necessary
Technically this code is limiting the containers to 2B objects or less, a more appropriate fix might be to return an appropriately signed version of size_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various cleanups for efficiency, including removing use of std::move, see notes. The use of std::move you had was actually causing the code to be potentially slower and was at the very least unnecessary.