chore(public/sendme.sh): POSIX compliance and verbosity#318
chore(public/sendme.sh): POSIX compliance and verbosity#318yermulnik wants to merge 1 commit inton0-computer:mainfrom
public/sendme.sh): POSIX compliance and verbosity#318Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Make `if`-conditional POSIX compliant to allow for `/bin/sh` that is not Bash * Wrap cmdline params to prevent globbing and word splitting * Add verbosity to `tar` to allow user to see where the binary is unpacked to
neuralpain
left a comment
There was a problem hiding this comment.
Should sed -E be used instead of sed -r for POSIX portability, as mentioned in the sed docs?
-E, -r, --regexp-extended
use extended regular expressions in the script
(for portability use POSIX -E).
On FreeBSD, where -r Same as -E for compatibility with GNU sed.So it should be fine I guess. UPD: let me know and I can update |
Okay, then there shouldn't be any issues. The current changes are good. |
|
@neuralpain Can you please dismiss your changes request? |
|
@Arqu Can we get an approval for this? |
if-conditional POSIX compliant to allow for/bin/shthat is not Bashtarto allow user to see where the binary is unpacked to