Merged
Conversation
Collaborator
muesli4
force-pushed
the
add-table-spec
branch
from
a7110f1 to
7e4c5b4
Compare
Owner
Author
|
@Xitian9, I don't mind rebasing. |
muesli4
force-pushed
the
add-table-spec
branch
from
7e4c5b4 to
158dc3e
Compare
Owner
Author
|
If it is too much for you, you don't have to go into detail. But you are obviously welcome to do so. And please be pedantic and let me know if you do not like a specific change. The first 3 commits are from #46.
|
muesli4
force-pushed
the
add-table-spec
branch
2 times, most recently
from
5c260fd to
a3628fb
Compare
Xitian9
reviewed
Nov 2, 2022
Xitian9
reviewed
Nov 2, 2022
Xitian9
reviewed
Nov 2, 2022
Xitian9
reviewed
Nov 2, 2022
Xitian9
reviewed
Nov 2, 2022
Xitian9
reviewed
Nov 2, 2022
muesli4
force-pushed
the
add-table-spec
branch
2 times, most recently
from
639552c to
2ea093e
Compare
Merged
muesli4
force-pushed
the
add-table-spec
branch
from
2ea093e to
8517523
Compare
Xitian9
reviewed
Nov 2, 2022
Refactor arguments of table functions into a separate type and provide smart constructors which ease creation.
* Restructure main module. * Capitalize titles. * Update outdated documentation. * Add missing documentation. * Clean up and simplify existing documentation.
* Rename functions to clearly state purpose. * Update documentation. * Refactor some uses.
muesli4
force-pushed
the
add-table-spec
branch
from
8517523 to
2940bdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently in the process of cleaning up. Since we are breaking compatibility anyway, I use this as an opportunity to restructure some of the code.