Fix list parse failing when encountering the S file mode bit - Issue #223 #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S bit means: "If the set-user-ID or set-group-ID bit is set but the corresponding executable bit is not set." As per: https://www.gnu.org/software/coreutils/manual/html_node/What-information-is-listed.html#index-permissions_002c-output-by-ls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to fix #223.
A server I tried to connect to has a directory with the S file mode bit set, node-ftp is currently unable to parse any line which contains that bit. According to the ls manual S is a valid file mode bit which means:
This pull request adds the S bit to the regex.