test: Fix test cases for timeZone difference #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test-parser.js` expects `Date` fields of files/directory to match with whatever specified in test case. However the expected date/time values doesn't specify timezone. Here is what [ES6 spec](http://www.ecma-international.org/ecma-262/6.0/#sec-date-time-string-format) says regaring missing timeZone. ```doc If the time zone offset is absent, the date-time is interpreted as a local time. ``` On the other hand, the information returned by `parseListEntry()` is alway in `UTC`. See ES6 spec for [Date constructor](http://www.ecma-international.org/ecma-262/6.0/#sec-date-year-month-date-hours-minutes-seconds-ms) Hence if someone running test cases in timeZone other than UTC will always see mismatch in timeZone as the actual date returned would be in UTC, while expected date would be in UTC equivalent of datetime specified in `expected` property. This issue has not surfaced in node+v8 because if timeZone is missing, it is interpreted as UTC. A quick test can verify this is FF nightly / Edge / Chrome ```js var x = new Date('2012-12-21T00:00:00.000'); x.toISOString(); // should be "2012-12-21T08:00:00.000Z" and not "2012-12-21T00:00:00.000Z" ```
icetee
added a commit
to icetee/node-ftp
that referenced
this pull request
Jul 25, 2017
mscdex#148 Thanks @ kunalspathak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-parser.jsexpectsDatefields of files/directory to match withwhatever specified in test case. However the expected date/time values
doesn't specify timezone.
Here is what ES6 spec says regaring missing timeZone.
On the other hand, the information returned by
parseListEntry()is alway inUTC.See ES6 spec for Date constructor
Hence if someone running test cases in timeZone other than UTC will always see mismatch
in timeZone as the actual date returned would be in UTC, while expected date would
be in UTC equivalent of datetime specified in
expectedproperty.This issue has not surfaced in node+v8 because if timeZone is missing, it is
interpreted as UTC.
A quick test can verify this is FF nightly / Edge / Chrome