-
Notifications
You must be signed in to change notification settings - Fork 91
Add bookmark banner to landing page #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds a glassmorphic "Bookmark us!" banner at the top of the landing page that displays the keyboard shortcut (⌘+D on Mac, Ctrl+D on Windows) to encourage users to bookmark the site. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughA new BookmarkBanner component is introduced to prompt users to bookmark the application. The component detects the user's operating system and displays platform-specific keyboard shortcuts (⌘D on macOS, Ctrl+D elsewhere). It is integrated into the home content page alongside existing UI elements. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚅 Deployed to the SMRY-pr-42 environment in smry
|
Greptile OverviewGreptile SummaryAdds a bookmark reminder banner to the landing page that displays platform-specific keyboard shortcuts (⌘+D for Mac, Ctrl+D for others). The banner integrates cleanly into the existing layout above the GitHub stars button.
The implementation has style concerns that deviate from the project's design philosophy. The banner uses inline Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Browser
participant HomeContent
participant BookmarkBanner
participant useIsMac
User->>Browser: Visit landing page
Browser->>HomeContent: Render component
HomeContent->>BookmarkBanner: Render banner (line 93)
BookmarkBanner->>useIsMac: Check platform
alt Server-side rendering
useIsMac-->>BookmarkBanner: true (SSR default)
BookmarkBanner-->>HomeContent: Render with ⌘
else Client-side hydration
useIsMac->>Browser: Check navigator.platform
Browser-->>useIsMac: Platform info
alt Mac platform
useIsMac-->>BookmarkBanner: true
BookmarkBanner-->>HomeContent: Render with ⌘
else Windows/Linux
useIsMac-->>BookmarkBanner: false
BookmarkBanner-->>HomeContent: Render with Ctrl
end
end
HomeContent-->>Browser: Display complete page
Browser-->>User: Show bookmark banner with keyboard shortcut
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
| backdropFilter: "blur(40px)", | ||
| WebkitBackdropFilter: "blur(40px)", | ||
| backgroundImage: | ||
| "linear-gradient(135deg, rgba(255, 255, 255, 0.3) 0px, rgba(0, 0, 0, 0) 100%), linear-gradient(100deg, rgba(255, 255, 255, 0.1) 25%, rgba(0, 0, 0, 0) 25%)", | ||
| boxShadow: | ||
| "rgba(255, 255, 255, 0.1) 0px 0px 0px 1px inset, rgba(0, 0, 0, 0.05) 0px 0px 0px 2px", | ||
| }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
violates design philosophy - uses inline style prop with hardcoded rgba values and complex gradients instead of semantic design tokens
Per DESIGN_PHILOSOPHY.md:
- Should use semantic tokens (
bg-accent,bg-card,border-border) that auto-adapt to dark mode - "Avoid hardcoded Tailwind colors (e.g.,
gray-100,gray-800)" - this applies to inline rgba values too - Backdrop blur effects with complex gradients don't match the "investor update" aesthetic
| backdropFilter: "blur(40px)", | |
| WebkitBackdropFilter: "blur(40px)", | |
| backgroundImage: | |
| "linear-gradient(135deg, rgba(255, 255, 255, 0.3) 0px, rgba(0, 0, 0, 0) 100%), linear-gradient(100deg, rgba(255, 255, 255, 0.1) 25%, rgba(0, 0, 0, 0) 25%)", | |
| boxShadow: | |
| "rgba(255, 255, 255, 0.1) 0px 0px 0px 1px inset, rgba(0, 0, 0, 0.05) 0px 0px 0px 2px", | |
| }} | |
| className="inline-flex items-center gap-2 rounded-lg border border-border bg-accent/50 px-3 py-2 text-xs text-foreground shadow-sm backdrop-blur-sm" |
Context Used: Context from dashboard - AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| <span | ||
| style={{ textShadow: "rgba(0, 0, 0, 0.05) 0px 1px 0px" }} | ||
| > | ||
| Bookmark us! | ||
| </span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline style prop with hardcoded rgba values should use Tailwind utility classes with semantic tokens instead
| <span | |
| style={{ textShadow: "rgba(0, 0, 0, 0.05) 0px 1px 0px" }} | |
| > | |
| Bookmark us! | |
| </span> | |
| <span> | |
| Bookmark us! | |
| </span> |
Context Used: Context from dashboard - AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.