chore: Upgrade Vite, Tailwind and React versions #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are the following things I changed: - I'm following this [tailwind upgrade guide](https://tailwindcss.com/docs/upgrade-guide). If there's a package (ie. https://blocks.tremor.so/blocks) that's using `v3`, we have to add `@config "../tailwind.config.js";` in `app.css` since it's not automatically detected by `v4`. - With React, I'm using `npx codemod@latest react/19/migration-recipe --prefix assets/` to update any affected codes (none) and following [Removed deprecated React APIs](https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-apis). - Bumped Vite version. - Minor changes like adding `cursor-pointer` on buttons (tbh I have no idea why), `context.jsx` to `context.tsx` in `live_react_examples.ex` and other [renamed Tailwind utilities](https://tailwindcss.com/docs/upgrade-guide#renamed-utilities). Ran mix test, smoke test, seems fine or maybe I missed something here.
mrdotb
requested changes
Apr 30, 2025
Owner
mrdotb
left a comment
mrdotb
left a comment
There was a problem hiding this comment.
👋 Thanks for the PR!
I tested the demo with the new version and everything looks good.
Just a couple of things I noticed:
- The
autoprefixerdependency doesn't seem to be used anymore. - This documentation section should be updated to reflect that:
https://github.com/mrdotb/live_react/blob/main/guides/installation.md#adjusting-your-own-packagejson
Also, could you please rebase and update the commit message to follow the conventional commits format?
Thanks!
Owner
Owner
|
Thank you for this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
For example:
fix: Multiply by appropriate coefficient, orfeat(Calculator): Correctly preserve historyAny explanation or long form information in your commit message should be
in a separate paragraph, separated by a blank line from the primary message
Related #39, #30, #29
Hi @mrdotb 👋🏾, thank you for this great library 🙏🏾. Here are the following things I changed:
v3, we have to add@config "../tailwind.config.js";inapp.csssince it's not automatically detected byv4.npx codemod@latest react/19/migration-recipe --prefix assets/to update any affected codes (none) and following Removed deprecated React APIs.cursor-pointeron buttons (tbh I have no idea why),context.jsxtocontext.tsxinlive_react_examples.exand other renamed Tailwind utilities.Ran mix test, smoke test, seems fine or maybe I missed something here. 🙏🏾🙏🏾🙏🏾