Inspector: Store parameters object+key #32507
Conversation
sunag
changed the title
| this.paramList = new Item( name ); | ||
|
|
||
| /** @type {Array<{ object:object, key:string, editor:object, subItem:Item }>} */ | ||
| this.data = []; |
| }; | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
There are some spaces in the code; you might need to format it using mrdoob code style.
|
|
||
| this._addParameter( object, property, editor, subItem ); | ||
|
|
||
| this._registerParameter( object, property, editor, subItem ); |
There was a problem hiding this comment.
Could you add _registerParameter() inside _addParameter() to simplify the code?
There was a problem hiding this comment.
It's what I did at first but the button method didnt call _addParameter - maybe an oversight?
There was a problem hiding this comment.
You can add a method exception for the button; that would simplify things anyway.
| /** @type {List} */ | ||
| this.paramList = paramList; | ||
|
|
||
| /** @type {Array<ParametersGroup>} */ |
There was a problem hiding this comment.
I would prefer to remove the js-doc now; we can do this entirely in another PR.
There was a problem hiding this comment.
Wouldn't this just be extra work later?
There was a problem hiding this comment.
That's because it needed to be redone anyway.
You can follow js-doc? The style of js-doc we use is different.
There was a problem hiding this comment.
I noticed :) If you prefer I can remove it (or change it to match the style if you can point me to an example or docs). I feel comfortable with js-doc (use it a lot in our js projects)
2 participants
Related issue: #32485
Description
Currently the inspector does not provide access to the objects and keys that are being controlled by the inspector UI.
This PR adds storing the parameters (object + key) in the parameters group to be accessible for external inspector tools (e.g. chrome extensions).
This contribution is funded by Needle