Move build dependencies into requirements.txt for Heroku compatibility #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y; remove build-requirements.txt
danielfmiranda
approved these changes
Apr 4, 2025
Contributor
danielfmiranda
left a comment
danielfmiranda
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @mmmavis 👍 approved!
| # Required on Heroku to prevent build failures with legacy packages like django-allauth | ||
| # Ensures build dependencies (e.g. setuptools, wheel) are installed before other packages | ||
| -r build-requirements.txt | ||
| # The two lines below are needed for Heroku compatibility. |
Contributor
There was a problem hiding this comment.
Kudos Thank you for updating the comment here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves build issues on Heroku by moving the
setuptoolsandwheeldependencies frombuild-requirements.txtinto the mainrequirements.txtfile.Heroku uses
requirements.txtas the default install target during the slug build process. Havingsetuptoolsandwheelthere ensures that packages likedjango-allauth, which rely on older setup.py behavior, install correctly without metadata generation errors.