feat: Added support for faststream >= 0.6.0 #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for faststream v0.6.0+ while maintaining backward compatibility with earlier versions. The implementation uses runtime version detection to conditionally import and define the appropriate middleware class.
- Removed the
faststream<0.6.0version constraint to support both old and new versions - Implemented version-specific implementations of
DIContextMiddlewarewith conditional imports - Updated CI workflow to test against both faststream version ranges
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| that_depends/integrations/faststream.py | Added version detection logic and two separate implementations of DIContextMiddleware for faststream <0.6.0 (deprecated) and >=0.6.0 (new API) |
| tests/integrations/faststream/test_faststream_di_pass_message.py | Added conditional imports and broker initialization based on faststream version |
| pyproject.toml | Removed faststream version constraint to allow any version |
| .github/workflows/ci.yml | Added matrix testing for both faststream version ranges |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit fde4dfc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.