fix(android): resolve crash due to null promise rejection code #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all instances of
Before:
After:
Context
In newer versions of React Native passing null as the rejection code throws a fatal
NullPointerException, crashing the appTested with
Related issue
Fixes #335
🚨 Immediate Workaround (Patch-Package)
If you cannot wait for the PR to be merged, do the following
patch-packageas a dev dependency in your react-native projectnode_modules/react-native-zip-archive/android/src/main/java/com/rnziparchive/RNZipArchiveModule.javapatches/react-native-zip-archive+x.x.x.patch"postinstall": "patch-package"to your package.json scripts to ensure that the fix applies after installation of node_modules